Re: [Xen-devel] [PATCH 2/3] x86: correctly check for subâleaf zero of leaf 7 in pv_cpuid()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/01/15 15:27, Jan Beulich wrote:
> Only the low 32 bits are relevant.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

There are two examples of "regs->eax" which could turn to regs->_eax
under the same argument; the if statement immediately after cpuid, and
the switch statement.

Either way,

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -916,7 +916,7 @@ void pv_cpuid(struct cpu_user_regs *regs
>          break;
>  
>      case 0x00000007:
> -        if ( regs->ecx == 0 )
> +        if ( regs->_ecx == 0 )
>              b &= (cpufeat_mask(X86_FEATURE_BMI1) |
>                    cpufeat_mask(X86_FEATURE_HLE)  |
>                    cpufeat_mask(X86_FEATURE_AVX2) |
>
>
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel