Re: [Xen-devel] [PATCH 4/4] xen/many: Drop redundant MAX_VIRT_CPUS bounds checks

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-01-19 at 11:21 +0000, Andrew Cooper wrote:
> In all 4 cases, visible in the context are bounds check against d->max_vcpus.
> Domain building will ensure that d->max_vcpus never exceeds an appropriate
> bound.  In the x86 case, different types of domains have different maxima for
> vcpus, making the checks wrong as opposed to simply redundant.
> 
> For vpsci in ARM, 'vcpuid' is an unsigned type so could never be less than 0.
> 
> For the common changes to do_{,compat}_vcpu_op(), these changes do result in a
> guest visible change, but only in so far as certain invalid vcpu ids will now
> fail with -ENOENT rather than -EINVAL.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>

For ARM: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel