Re: [Xen-devel] [PATCH] tools/libxl: Correct static pattern rule for pkgconfig files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-01-27 at 20:34 +0000, Andrew Cooper wrote:
> Attempting to build libxl causes Make to emit the following warnings
> 
> andrewcoop@andrewcoop:xen.git$ make -C tools/libxl all
> ...
> Makefile:253: target `xenlight.pc' doesn't match the target pattern
> Makefile:253: target `xlutil.pc' doesn't match the target pattern
> ...
> 
> because the static pattern rule is malformed.  'Makefile' as the only
> prereq-pattern does not contain a pattern.
> 
> The rule ends up working because of the use of $@.in where $< should have been
> used, but lacked any dependency between a $FOO.pc and its .in source file.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked + applied, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel