Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in 
remove/destroy functions"):
> Perhaps better would be to add a new parameter to0 DEFINE_DEVICE_REMOVE
> like extra_setdefault_args which is pasted in the appropriate place?

I don't think this is right because...

> I suppose on remove its not so much a case of choosing a suitable
> backend as reflecting the actual current reality for that device. Which
> suggests that libxl__device_from_disk ought to be figuring out the
> actual backend somehow rather than being told it.

... yes.  To remove a device you need to tear down the actual backend,
not whatever the default might be.  libxl_domain_destroy must be able
to do this, surely ?  (I haven't checked the code...)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel