Re: [Xen-devel] [PATCH 3/5] hvmemul_do_io: If the send to the ioreq server failed do not retry.

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 02/02/15 05:14, Jan Beulich wrote:
>>>> On 02.02.15 at 11:06, <Paul.Durrant@xxxxxxxxxx> wrote:
>>>  -----Original Message-----
>>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>>> Sent: 02 February 2015 10:04
>>> To: Paul Durrant; Don Slutz
>>> Cc: Andrew Cooper; George Dunlap; Ian Campbell; Ian Jackson; Stefano
>>> Stabellini; Wei Liu; xen-devel@xxxxxxxxxxxxx; Keir (Xen.org)
>>> Subject: RE: [PATCH 3/5] hvmemul_do_io: If the send to the ioreq server
>>> failed do not retry.
>>>
>>>>>> On 02.02.15 at 10:51, <Paul.Durrant@xxxxxxxxxx> wrote:
>>>>> From: Don Slutz [mailto:dslutz@xxxxxxxxxxx]
>>>>> --- a/xen/arch/x86/hvm/hvm.c
>>>>> +++ b/xen/arch/x86/hvm/hvm.c
>>>>> @@ -2507,9 +2507,45 @@ int hvm_buffered_io_send(ioreq_t *p)
>>>>>      return 1;
>>>>>  }
>>>>>
>>>>> -bool_t hvm_has_dm(struct domain *d)
>>>>> +static bool_t hvm_complete_assist_req(ioreq_t *p)
>>>>
>>>> You'll need to change this to a void return as Jan requested.
>>>
>>> I don't think I did.
>>
>> Oh, sorry. I thought you suggested that the constant return of 1 from 
>> hvm_complete_assist_req() was a bad idea.
> 
> Oh, I see, but that was in another thread, and I really suggested to
> remove the function altogether (folding it back into its only caller).
> 

I was planing to also do this.  This is why the code was not in patch form.

   -Don Slutz

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel