Re: [Xen-devel] [PATCH] tools/libxc: Don't leave scratch_pfn uninitialised if the domain has no memory

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2015-01-28 at 15:52 +0000, Andrew Cooper wrote:
> c/s 5b5c40c0d1 "libxc: introduce a per architecture scratch pfn for temporary
> grant mapping" accidentally an issue whereby there were two paths out of
> xc_core_arch_get_scratch_gpfn() which returned 0, but only one of which
> assigned a value to the gpfn parameter.
> 
> xc_domain_maximum_gpfn() can validly return 0, at which point gpfn 1 is a
> valid scratch page to use.
> 
> In addition, widen rc before adding 1 and possibly overflowing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked + applied, thanks.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel