Re: [Xen-devel] [PATCH 6/7] build system: stubdom targets now depends on mini-os target

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-02-02 at 17:18 +0000, Wei Liu wrote:
> On Mon, Feb 02, 2015 at 03:03:45PM +0000, Ian Campbell wrote:
> > On Mon, 2015-02-02 at 15:01 +0000, Ian Campbell wrote:
> > > On Mon, 2015-02-02 at 12:59 +0000, Wei Liu wrote:
> > > > Provide mini-os url and revision in Config.mk
> > > > 
> > > > Introduce Makefile.mini-os which contains mini-os specific targets.
> > > 
> > > I'm not sure it has enough content to warrant that, those two targets
> > > could easily be inlined.
> > > 
> > > > +ifeq ($(wildcard $(MINI_OS)/Config.mk),)
> > > > +$(error Please run `make mini-os-dir' in top-level directory)
> > > > +endif
> > > 
> > > This makes me think that maybe my earlier suggestion to move the clone
> > > under stubdom/ might be better done right away.
> > > 
> > > In fact, that would avoid the need to play tricks with renaming extras/
> > > too, since you could build both for a commit.
> > 
> > Retracted after reponse to my earlier suggestion...
> > 
> 
> I take it you're fine with the current arrangement now?

I suppose "willing to tolerate" might be closer, but yes ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel