Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v5 9/9] mfi-common, make-flight: 
create XSM test jobs"):
> On Tue, 2015-02-03 at 12:06 +0000, Wei Liu wrote:
> > +      if [ "x$xsm" = "xtrue" -a "x$platform" != "x" ]; then
> 
> IIRC Ian previously indicated that he prefers to avoid " when it is
> unnecessary, which I think is the case for all 4 words above.

I don't actually mind.

I think my comment that you are thinking of may have been an
explanation of why I had done it that way in some code of my own, but
I think either way is acceptable.

Being consistent with surrounding code is usually helpful of course.

</bikeshed>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel