Re: [Xen-devel] [PATCH OSSTEST v5 4/9] mfi-common: create build-$arch-xsm job

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-02-03 at 13:48 +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH OSSTEST v5 4/9] mfi-common: create build-$arch-xsm 
> job"):
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> > Changes in v4:
> > 1. Use "true" and "false" instead of "y" and "n".
> 
> Is this something that I or Ian C suggested ?  It seems to lead to
> extra fiddly code in ts-xen-build to convert it back.

I think it was me...

> Currently make-flight and mfi-common have both y/n and true/false,
> depending on the consumer.

... because I (incorrectly?) observed that true/false was what was in
use elsewhere in runvars (maybe not in the code though?).

$ ./mg-show-flight-runvars 33637 | awk '$3 ~ /true|false/ { print $0}' 
build-amd64                               enable_ovmf                 true
build-armhf                               enable_ovmf                 true
build-i386                                enable_ovmf                 true
build-amd64                               enable_xend                 false
build-armhf                               enable_xend                 false
build-i386                                enable_xend                 false
$ ./mg-show-flight-runvars 33637 | awk '$3 ~ /^[yn]$/ { print $0}' 
$

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel