Re: [Xen-devel] [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH 2/4] libxl: vcpuset: Check max_vcpus 
argument against the maximum number of vCPUs the guest has set."):
> The maximum number of VCPUs the guest can have is determined during
> domain creation and is set by 'maxvcpus' parameter (in the guest
> config). Trying to set the amount of vCPUs above said value
> in vcpuset will result in an error - and we can catch it here
> (instead of later in the function) and print a nice warning to the user.
...
> +    rc = libxl_domain_info(ctx, &dominfo, domid);
> +    if (rc == ERROR_INVAL) {
> +        fprintf(stderr, "Error: Domain %u does not exist.\n", domid);
> +        return -rc;

Do we really return ERROR_INVAL for this ?  ...   Looks like we do.

OK then, although we are definitely going to have to change that at
some point.  How tiresome.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel