Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-02-03 at 16:23 +0000, Andrew Cooper wrote:
> On 03/02/15 16:18, Ian Campbell wrote:
> > On Tue, 2015-02-03 at 16:06 +0000, Andrew Cooper wrote:
> >> On 03/02/15 15:54, Olaf Hering wrote:
> >>> Including a timestamp into the binary makes it impossible to get
> >>> reproducible binaries. Remove the timestamp because it carries no
> >>> valuable info.
> >>>
> >>> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> >>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >>> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> In this case, it would appear that the vgabios_date symbol is completely
> >> unused inside the binary.  Good riddance!
> > I think it is actually used because the string at vgabios_version
> > (deliberately) falls through.
> 
> Oh - so it does.  (I misread that as an .asciz).

I'm not going to pretend I spotted it the first time either ;-)

> > Olof, you just removed the nul terminator used there AFAICT. At best
> > this means that the vgabios_copyright is printed twice.
> 
> In which case the 0a/0d and NUL characters need to stay, although the
> single space above vgabios_date can be discarded.

True. (Subject to what Jan wondered about scanning for BIOS strings...)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel