Re: [Xen-devel] [PATCH v2 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 02/03/15 06:05, Jan Beulich wrote:
>>>> On 02.02.15 at 16:22, <dslutz@xxxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -2573,6 +2573,7 @@ bool_t hvm_send_assist_req_to_ioreq_server(struct 
>> hvm_ioreq_server *s,
>>  
>>  static bool_t hvm_complete_assist_req(ioreq_t *p)
>>  {
>> +    ASSERT(p->type != IOREQ_TYPE_PCI_CONFIG);
>>      switch ( p->type )
>>      {
>>      case IOREQ_TYPE_COPY:
> 
> The better variant would seem to be case IOREQ_TYPE_PCI_CONFIG
> with ASSERT_UNREACHABLE().
> 

Ok, Will change (since there will be a v3)
    -Don Slutz


> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel