Re: [Xen-devel] [PATCH RFC 06/35] ACPI: Add Generic Interrupt and Distributor struct

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Parth,

On 04/02/2015 14:01, parth.dixit@xxxxxxxxxx wrote:
> From: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
>
> Add Generic Interrupt and Distributor (ACPI 5.0) structure.
>
> Signed-off-by: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
> ---
>   xen/include/acpi/actbl1.h | 29 ++++++++++++++++++++++++++++-
>   1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/xen/include/acpi/actbl1.h b/xen/include/acpi/actbl1.h
> index 9311e3a..dd6dc27 100644
> --- a/xen/include/acpi/actbl1.h
> +++ b/xen/include/acpi/actbl1.h
> @@ -639,7 +639,9 @@ enum acpi_madt_type {
>         ACPI_MADT_TYPE_INTERRUPT_SOURCE = 8,
>         ACPI_MADT_TYPE_LOCAL_X2APIC = 9,
>         ACPI_MADT_TYPE_LOCAL_X2APIC_NMI = 10,
> -       ACPI_MADT_TYPE_RESERVED = 11    /* 11 and greater are reserved */
> +       ACPI_MADT_TYPE_GENERIC_INTERRUPT = 11,
> +       ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR = 12,
> +       ACPI_MADT_TYPE_RESERVED = 13    /* 13 and greater are reserved */
>   };
>
>   /*
> @@ -760,6 +762,31 @@ struct acpi_madt_local_x2apic_nmi {
>         u8 reserved[3];
>   };
>
> +/* 11: Generic Interrupt (ACPI 5.0) */
> +
> +struct acpi_madt_generic_interrupt {
> +    struct acpi_subtable_header header;
> +    u16 reserved;           /* reserved - must be zero */
> +    u32 gic_id;
> +    u32 uid;
> +    u32 flags;
> +    u32 parking_version;
> +    u32 performance_interrupt;
> +    u64 parked_address;
> +    u64 base_address;
> +};
> +
> +/* 12: Generic Distributor (ACPI 5.0) */
> +
> +struct acpi_madt_generic_distributor {
> +    struct acpi_subtable_header header;
> +    u16 reserved;           /* reserved - must be zero */
> +    u32 gic_id;
> +    u64 base_address;
> +    u32 global_irq_base;
> +    u32 reserved2;          /* reserved - must be zero */
> +};
> +
This file is using tablutation rather than space for indent

>   /*
>    * Common flags fields for MADT subtables
>    */
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel