Re: [Xen-devel] [PATCH RFC 02/35] xen: arm64: ACPI: Support common ACPI drivers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-02-05 at 11:35 +0000, Jan Beulich wrote:
> >>> On 05.02.15 at 12:04, <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Wed, 2015-02-04 at 17:36 +0000, Julien Grall wrote:
> >> I would move the whole function (acpi_os_map_memory) per-architecture.
> > 
> > That's an option too, since once the "/* The low first Mb is always
> > mapped. */" bit is removed (which it should be since it is x86 specific)
> > then there isn't much left.
> 
> But it's an OS interface function ACPI CA wants, and as such it
> belongs into osl.c.

OK, then it certainly needs an X86 ifdef around the first-Mb stuff, and
for the __acpi_map thing to be arch specific rather than ifdef'd.

Ian



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel