[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCHv5] x86/xen: allow privcmd hypercalls to be preempted



On 02/05/2015 11:14 AM, David Vrabel wrote:
On 05/02/15 16:11, Boris Ostrovsky wrote:
On 02/05/2015 07:41 AM, David Vrabel wrote:
+
+void xen_maybe_preempt_hcall(void)
+{
+    if (__this_cpu_read(xen_in_preemptible_hcall)) {
Can you check should_resched() here?
_cond_resched() already does this.


Right, you'd be checking it twice, but since in most cases you won't need to reschedule you will then avoid making unnecessary call (and per-cpu updates).

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.