Re: [Xen-devel] [PATCH] tools: work around collision of -O0 and -D_FORTIFY_SOURCE

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.02.15 at 17:56, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Jan Beulich writes ("Re: [PATCH] tools: work around collision of -O0 and 
>> > --- a/tools/Rules.mk
>> > +++ b/tools/Rules.mk
>> > @@ -56,7 +56,7 @@ SHLIB_libxenvchan  = -Wl,-rpath-link=$(XEN_LIBVCHAN)
>> >  
>> >  ifeq ($(debug),y)
>> >  # Disable optimizations and enable debugging information for macros
>> > -CFLAGS += -O0 -g3
>> > +CFLAGS += -O0 -g3 $(PY_NOOPT_CFLAGS)
>> 
>> Why would you do this for all of the tools build rather than just the
>> python components?
> 
> You're right.  This should be something like:
> 
>   CFLAGS += -O0 -g3
>  +PY_CFLAGS += $(PY_NOOPT_CFLAGS)
> 
> and including PY_CFLAGS in tools/python/Makefile etc.

Attached the patch I used for testing. While it works okay for me,
I guess the configure part will need further taking care of the
-Wp,-D... variant Don is seeing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel