Re: [Xen-devel] [OSSTEST PATCH 05/10] sg-run-job: testid generation: Move spawn-step-begin

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-02-06 at 19:17 +0000, Ian Jackson wrote:
> Run spawn-step-begin until after the loop over $args, and after the
> computation of the basic deftestid.
> 
> No functional change: nothing in that loop looks at stepno.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

TBH any Ack I gave here (and to the following TCL patches) would be
pretty cursory. I agree with what you seem to be trying to do even if
I'm not really in a position to confirm it's what you are actually
achieving. I think you can be trusted, and you are running a test
flight, and osstest has a push gate of its own. IOW I think you should
go ahead on patches 5..8 without an explicit ack...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel