Re: [Xen-devel] [PATCH v3 25/27] ArmVirtualizationPkg: add XenIoMmioLib

[Laszlo Ersek <lersek@xxxxxxxxxx>]

On 02/03/15 20:20, Ard Biesheuvel wrote:
> This adds a XenIoMmioLib declaration and implementation that can
> be invoked to install the XENIO_PROTOCOL and a corresponding
> grant table address on a EFI handle.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
>  OvmfPkg/Include/Library/XenIoMmioLib.h        |  64 ++++++++++
>  OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c   | 166 
> ++++++++++++++++++++++++++
>  OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf |  39 ++++++
>  OvmfPkg/OvmfPkg.dec                           |   4 +
>  4 files changed, 273 insertions(+)
>  create mode 100644 OvmfPkg/Include/Library/XenIoMmioLib.h
>  create mode 100644 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c
>  create mode 100644 OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.inf

There are two occurrences of the typo "if if" in this patch. In case you
send a v4, please fix that.

Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx>

I'm done with the v3 review; you addressed all my v2 comments.

Thanks!
Laszlo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel