Re: [Xen-devel] [PATCH v3 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Don Slutz [mailto:dslutz@xxxxxxxxxxx]
> Sent: 10 February 2015 22:52
> To: xen-devel@xxxxxxxxxxxxx; Jan Beulich; Paul Durrant
> Cc: Andrew Cooper; George Dunlap; Ian Campbell; Ian Jackson; Keir
> (Xen.org); Stefano Stabellini; Wei Liu; Don Slutz
> Subject: [PATCH v3 2/3] hvm_complete_assist_req: We should not be able to
> get here on IOREQ_TYPE_PCI_CONFIG
> 
> Suggested-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
> v3:
>       Move ASSERT() into switch and use ASSERT_UNREACHABLE().
> 
> 
>  xen/arch/x86/hvm/hvm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index b03ee4e..1e722fc 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2632,6 +2632,9 @@ static bool_t hvm_complete_assist_req(ioreq_t *p)
>  {
>      switch ( p->type )
>      {
> +    case IOREQ_TYPE_PCI_CONFIG:
> +        ASSERT_UNREACHABLE();
> +        break;
>      case IOREQ_TYPE_COPY:
>      case IOREQ_TYPE_PIO:
>          if ( p->dir == IOREQ_READ )
> --
> 1.8.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel