Re: [Xen-devel] [PATCH OSSTEST 05/12] Add and expose some testsupport APIs

["Hu, Robert" <robert.hu@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: Wednesday, February 11, 2015 10:54 PM
> To: Hu, Robert
> Cc: xen-devel@xxxxxxxxxxxxx; jfehlig@xxxxxxxx; wei.liu2@xxxxxxxxxx;
> ian.campbell@xxxxxxxxxx; Pang, LongtaoX
> Subject: Re: [PATCH OSSTEST 05/12] Add and expose some testsupport APIs
> 
> Robert Ho writes ("[PATCH OSSTEST 05/12] Add and expose some testsupport
> APIs"):
> > When install L2 guest, we will need to invoke
> >  'select_ether' to get guest MAC address. So here expose select_ether().
> 
> I'm not sure whether you actually need to do this.  I will look at the
> rest of your series to see why prepareguest() isn't suitable.  But
> this part of the patch is fine in principle.
> 
> > And
> 
> These seem like two indepenedent patches.  They should be split up.
> 
> >  also, we added another function 'guest_editconfig_cd' and expose it.
> >   This function bascically changes guest boot device sequence and
> >  alter its on_reboot behavior to restart.
> 
> I don't understand why guest_editconfig_nocd isn't sufficient.
Em..., seems guest_editconfig_nocd can achieve my purpose as well.
I would try to reuse it in next sending.
I guess, originally I composed another function was to avoid the risk
of breaking down existing functions, given the situation I know little about 
your
design mind. Now that we changed our mind to
reuse existing functions as much as possible, I should have eliminated
these old-time addings.
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel