Re: [Xen-devel] [PATCH v5 23/24] xl: introduce xcalloc

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 12, 2015 at 08:17:42PM +0000, Andrew Cooper wrote:
> On 12/02/15 19:44, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > ---
> >  tools/libxl/xl_cmdimpl.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 440db78..ec7fb2d 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -289,6 +289,18 @@ static void *xmalloc(size_t sz) {
> >      return r;
> >  }
> >  
> > +static void *xcalloc(size_t n, size_t sz) __attribute__((unused));
> > +static void *xcalloc(size_t n, size_t sz) {
> > +    void *r;
> > +    r = calloc(n, sz);
> 
> These two lines can be joined, espcially in a small wrapper like this.
> 
> > +    if (!r) {
> > +        fprintf(stderr,"xl: Unable to calloc %lu bytes.\n",
> > +                (unsigned long)sz * (unsigned long)n);
> 
> %zu is the correct format identifier for a size_t, and it will allow you
> to drop the casts.
> 

Both issues fixed. Thanks for reviewing.

Wei.

> ~Andrew
> 
> > +        exit(-ERROR_FAIL);
> > +    }
> > +    return r;
> > +}
> > +
> >  static void *xrealloc(void *ptr, size_t sz) {
> >      void *r;
> >      if (!sz) { free(ptr); return 0; }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel