Re: [Xen-devel] [PATCH v5 05/24] libxc: allocate memory with vNUMA information for PV guest

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Feb 13, 2015 at 02:30:30PM +0000, Andrew Cooper wrote:
> On 12/02/15 19:44, Wei Liu wrote:
> > diff --git a/tools/libxc/xc_private.h b/tools/libxc/xc_private.h
> > index 45b8644..1809674 100644
> > --- a/tools/libxc/xc_private.h
> > +++ b/tools/libxc/xc_private.h
> > @@ -35,6 +35,8 @@
> >  
> >  #include <xen/sys/privcmd.h>
> >  
> > +#define XC_VNUMA_NO_NODE (~0U)
> 
> Shouldn't this sentinel value come from the Xen public API?
> 

Xen public headers don't have a NUMA_NO_NODE though. Do you want me
to add one to memory.h?

Wei.

> ~Andrew
> 
> > +
> >  #if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && 
> > !defined(__MINIOS__)
> >  /* Compile in Valgrind client requests? */
> >  #include <valgrind/memcheck.h>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel