Re: [Xen-devel] [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Feb 13, 2015 at 03:26:49PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v5 19/24] libxl: define LIBXL_HAVE_VNUMA"):
> > There is no new API yet. Just new structure to specify vNUMA
> > configuration.
> > 
> > How about this:
> > 
> > /* LIBXL_HAVE_VNUMA
> >  *
> >  * If this is defined, libxl's IDL has libxl_vnode_info and there is a
> >  * array call vnuma_nodes inside libxl_domain_build_info to specify
> >  * vNUMA configuration.
> >  */
> 
> Yes, something like that.  It would be better if the precise wording
> were more similar to that for the other HAVE macros.  How about:
> 
>    * If this is defined the type libxl_vnode_info exists, and a
>    * field 'vnuma_nodes' is present in libxl_domain_build_info.
> 
> or similar ?

That's good.

Wei.

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel