Re: [Xen-devel] [PATCH v5 07/24] libxl: add vmemrange to libxl__domain_build_state

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 16, 2015 at 04:00:19PM +0000, Dario Faggioli wrote:
> On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:
> > A vnode consists of one or more vmemranges (virtual memory range).  One
> > example of multiple vmemranges is that there is a hole in one vnode.
> > 
> > Currently we haven't exported vmemrange interface to libxl user.
> > Vmemranges are generated during domain build, so we have relevant
> > structures in domain build state.
> > 
> > Later if we discover we need to export the interface, those structures
> > can be moved to libxl_domain_build_info as well.
> > 
> > These new fields (along with other fields in that struct) are set to 0
> > at start of day so we don't need to explicitly initialise them. A
> > following patch which introduces an independent checking function will
> > need to access these fields. I don't feel very comfortable squashing
> > this change into that one so I didn't use a single commit.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Cc: Elena Ufimtseva <ufimtseva@xxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> > ---
> > Changes in v5:
> > 1. Fix commit message.
> > 
> > Changes in v4:
> > 1. Improve commit message.
> > 
> > Changes in v3:
> > 1. Rewrite commit message.
> >
> This is a rather amusing changes history, allow me to say! :-D :-D
> 

I find myself writing confusing things all the time.  :-)

> Regards,
> Dario
> 
> PS. The patch (as well as others) has Ian's ack already, so I know my
> rev-by tag is rather pointless. However, as I've been involved in the
> process, I'd still like to point out I've looked at and am ok with this.
> Feel free not to incorporate the tag if you don't want to, or if you're
> not resending some of the patches.

More eyes are always good.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel