Re: [Xen-devel] [PATCH v5 17/24] libxl: build, check and pass vNUMA info to Xen for HVM guest

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 17, 2015 at 02:26:23PM +0000, Dario Faggioli wrote:
> On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:
> 
> > --- a/tools/libxc/xc_hvm_build_x86.c
> > +++ b/tools/libxc/xc_hvm_build_x86.c
> > @@ -407,7 +407,7 @@ static int setup_guest(xc_interface *xch,
> >              new_memflags |= XENMEMF_exact_node_request;
> >          }
> >  
> > -        end_pages = args->vmemranges[i].end >> PAGE_SHIFT;
> > +        end_pages = args->vmemranges[vmemid].end >> PAGE_SHIFT;
> >
> What's this? I suspect this should be using vmemid already in patch 16,
> shouldn't it?
> 

This hunk belongs to previous patch. It should be squashed to previous
one.

> Other than this,
> 
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 

Thanks.

Wei.

> Regards,
> Dario



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel