Re: [Xen-devel] [PATCH v2 5/9] xen: arm: Handle CP15 register traps from userspace

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 10/02/15 04:45, Ian Campbell wrote:
>      default:
> @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs 
> *regs)
>          advance_pc(regs, hsr);
>          break;
>      case HSR_EC_CP15_32:
> -        if ( !is_32bit_domain(current->domain) )
> -            goto bad_trap;
> +        BUG_ON(!psr_mode_is_32bit(regs->cpsr));

It's a bit strange that on the previous patch (#5) you fixed CP15_64 but
not CP15_32. If I'm not mistaken you need both in-order to make the
things correctly work.

So, I would invert the 2 patches.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel