Re: [Xen-devel] [PATCH v5 10/24] libxl: functions to build vmemranges for PV guest

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 17, 2015 at 03:28:15PM +0000, Dario Faggioli wrote:
> On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:
> 
> > --- a/tools/libxl/libxl_x86.c
> > +++ b/tools/libxl/libxl_x86.c
> > @@ -339,6 +339,79 @@ int 
> > libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
> >      return 0;
> >  }
> >  
> > +/* Return 0 on success, ERROR_* on failure. */
> > +int libxl__arch_vnuma_build_vmemrange(libxl__gc *gc,
> > +                                      uint32_t domid,
> > +                                      libxl_domain_build_info *b_info,
> > +                                      libxl__domain_build_state *state)
> >
> The doc comment does not look super useful as it is... ERRROR_* is
> ERROR_NOMEM, right?
> 

It could also be ERROR_FAIL, if e820_host_sanitize fails.

> Perhaps say that, along with a few words on when it happens (or just get
> rid of the comment entiretly)
> 
> In any case,
> 
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 

Thanks.

Wei.

> Dario



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel