[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.



On 17/02/15 18:30, Tamas K Lengyel wrote:
>> All these whitespace changes here and further down don't really
>> belong in this patch - please again get this right when adding the
>> code.
> Same issue I mentioned in the other patch: git -M can't track the
> files if indentation is fixed as part of the renaming process. As I
> end up touching all the files that have with minor style issues like
> this in the series as a result of the renaming, I fix them as I go
> along. If that stretches the rules, I will need to add a whole new
> separate patch just for indentation fixing.

Separating the two is best for review.

One patch which git diff -M says is identical for moving the file, and
one patch which git diff -w says is identical for whitespace fixes.

It makes it trivial to confirm that there is no functional change involved.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.