Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2015-02-11 at 07:50 +0000, Jan Beulich wrote:
> All,
> 
> I'd like to propose to honor the 'd' in these functions' names (which
> I understand to mean "debug") in that such functions should be
> no-ops in non-debug builds. I'd then be inclined to introduce a
> gprintk() automatically adding XENLOG_GUEST and the printing of
> current using the %pv format.

Sounds fine to me.

>  Quite likely the (mis-)use of these
> two functions may then temporarily result in messages not meant
> to be debugging ones to become hidden in non-debug builds. If
> others agree, I'd try to make one pass through the tree to try to
> identify such,

Thanks, that would be useful I think. Will you cover arch/arm too?

> but I'd like to ask others to also keep an eye on that aspect.

I'll certainly try.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel