[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return

To: Bob Liu <bob.liu@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
From: David Vrabel <dvrabel@xxxxxxxxxx>
Date: Thu, 19 Feb 2015 16:51:20 +0000
Cc: axboe@xxxxxx, felipe.franciosi@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, david.vrabel@xxxxxxxxxx, avanzini.arianna@xxxxxxxxx, roger.pau@xxxxxxxxxx
Delivery-date: Thu, 19 Feb 2015 16:53:02 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>


On 15/02/2015 08:19, Bob Liu wrote:

Move the request complete logic out of blkif_interrupt() to a work queue,
after that we can replace 'spin_lock_irq' with 'spin_lock' so that irq won't
be disabled too long in blk_mq_queue_rq().

I think using a threaded interrupt (like scsifront) is better than work.Also, this seems orthogonal to the multiqueue support. Is it a usefulbug fix on its own?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [RFC PATCH 00/10] Multi-queue support for xen-block driver
  - From: Bob Liu
- [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return
  - From: Bob Liu

Prev by Date: Re: [Xen-devel] [PATCHv6] x86/xen: allow privcmd hypercalls to be preempted
Next by Date: Re: [Xen-devel] [PATCH 07/10] xen/blkback: pseudo support for multi hardware queues
Previous by thread: [Xen-devel] [PATCH 10/10] xen/blkfront: use work queue to fast blkif interrupt return
Next by thread: Re: [Xen-devel] [RFC PATCH 00/10] Multi-queue support for xen-block driver
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.