Re: [Xen-devel] [PATCH v3 05/24] xen/arm: vgic: Introduce a function to initialize pending_irq

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
> The structure pending_irq is initialized on the same way in 2 differents

"in the same way in 2 different places".

> place. Introduce vgic_init_pending_irq to avoid code duplication.
> 
> Also move the setting of the irq field in this function as we need to

"...into this function..."

> initialize it once rather than every time an IRQ is injected to the guest.
> 
> Finally, use unsigned int for the "irq" field to be consistent with the
> virq variable
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel