[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index

To: Julien Grall <julien.grall@xxxxxxxxxx>
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 20 Feb 2015 16:55:14 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, tim@xxxxxxx, stefano.stabellini@xxxxxxxxxx
Delivery-date: Fri, 20 Feb 2015 17:36:57 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
> There is no reason to use signed integer for an index.

Did you check for now pointless "if ( uthing < 0 ) which a picky
compiler might whinge about?

> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index
  - From: Julien Grall

Prev by Date: Re: [Xen-devel] [PATCH v3 00/24] xen/arm: Add support for non-pci passthrough
Next by Date: Re: [Xen-devel] [PATCH v3 15/24] xen/dts: Provide an helper to get a DT node from a path provided by a guest
Previous by thread: Re: [Xen-devel] [PATCH v3 00/24] xen/arm: Add support for non-pci passthrough
Next by thread: Re: [Xen-devel] [PATCH v3 14/24] xen/dts: Use unsigned int for MMIO and IRQ index
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.