Re: [Xen-devel] [PATCH v3 19/24] xen/iommu: arm: Wire iommu DOMCTL for ARM

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(although this does seem to suggest that my decision to use
subarch_do_domctl was flawed -- I should just have inlined
XEN_DOMCTL_set_address_size with a call to a subarch helper)

> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> 
> ---
>     Changes in v3:
>         - Add Stefano's ack
> 
>     Changes in v2:
>         - Don't move the call in common code.
> ---
>  xen/arch/arm/domctl.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 485d3aa..cc4894e 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -33,7 +33,16 @@ long arch_do_domctl(struct xen_domctl *domctl, struct 
> domain *d,
>          return p2m_cache_flush(d, s, e);
>      }
>      default:
> -        return subarch_do_domctl(domctl, d, u_domctl);
> +    {
> +        int rc;
> +
> +        rc = subarch_do_domctl(domctl, d, u_domctl);
> +
> +        if ( rc == -ENOSYS )
> +            rc = iommu_do_domctl(domctl, d, u_domctl);
> +
> +        return rc;
> +    }
>      }
>  }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel