Re: [Xen-devel] [PATCH] xen: Minor modifications to platform.h to make it C++-friendly

[Tim Deegan <tim@xxxxxxx>]

At 10:54 +0000 on 23 Feb (1424685241), Jan Beulich wrote:
> ... this should be moved out to file scope too, both for consistency
> and to avoid an eventual further adjustment going forward. Otoh
> I'm not convinced we need the headers to be C++ ready (nor am
> I convinced that there aren't any other obstacles preventing their
> unmodified use in C++). Co-maintainers, what do you think?

In general I'm against making C code uglier to keep C++ compilers
happy (e.g. ISTR vetoing the idea of putting 'extern C' runes in our
header files a while back).  And we certainly don't _support_ the
header files as C++.

OTOH, I think that just defining struct xenpf_efi_guid and struct
xenpf_efi_time at file scope would be fine here -- if anything it's
nicer to have these reused structs defined before first use.
And if it happens to solve a problem for C++, too, that's great. :)

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel