Re: [Xen-devel] [PATCH v3 24/24] xl: Add new option dtdev

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote:
> The option "dtdev" will be used to passthrough a non-PCI device described
> in the device tree to a guest.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> ---
>     Changes in v2:
>         - libxl_device_dt has been rename to libxl_device_dtdev
>         - use xrealloc instead of realloc
> ---
>  docs/man/xl.cfg.pod.5    |  5 +++++
>  tools/libxl/xl_cmdimpl.c | 21 ++++++++++++++++++++-
>  2 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> index 225b782..cfd3d5f 100644
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -721,6 +721,11 @@ More information about Xen gfx_passthru feature is 
> available
>  on the XenVGAPassthrough L<http://wiki.xen.org/wiki/XenVGAPassthrough>
>  wiki page.
>  
> +=item B<dtdev=[ "DTDEV_PATH", "DTDEV_PATH", ... ]>
> +
> +Specifies the host device node to passthrough to this guest. Each DTDEV_PATH
                            ^tree?

s/node/nodes/ either way.
 
> +is the absolute path in the device tree.

Can it be an alias?

>  =item B<ioports=[ "IOPORT_RANGE", "IOPORT_RANGE", ... ]>
>  
>  Allow guest to access specific legacy I/O ports. Each B<IOPORT_RANGE>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 31e89e8..80c9df6 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -986,7 +986,7 @@ static void parse_config_data(const char *config_source,
>      long l;
>      XLU_Config *config;
>      XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms;
> -    XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian;
> +    XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs;
>      int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian;
>      int pci_power_mgmt = 0;
>      int pci_msitranslate = 0;
> @@ -1746,6 +1746,25 @@ skip_vfb:
>              libxl_defbool_set(&b_info->u.pv.e820_host, true);
>      }
>  
> +    if (!xlu_cfg_get_list (config, "dtdev", &dtdevs, 0, 0)) {
> +        d_config->num_dtdevs = 0;
> +        d_config->dtdevs = NULL;
> +        for (i = 0; (buf = xlu_cfg_get_listitem(dtdevs, i)) != NULL; i++) {
> +            libxl_device_dtdev *dtdev;
> +
> +            d_config->dtdevs = (libxl_device_dtdev *) 
> xrealloc(d_config->dtdevs, sizeof (libxl_device_dtdev) * 
> (d_config->num_dtdevs + 1));

Please wrap the long line.

(I know there is some bad precedent in this file...)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel