Re: [Xen-devel] [PATCH] xsm/flask: Handle policy load failures properly

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 23, 2015 at 11:11:39AM -0500, Daniel De Graaf wrote:
[...]
> -    if ( flask_enforcing )
> +    if ( ret && policy_size )
> +        panic("Flask: Unable to load XSM policy");
> +
> +    if ( ret )
> +        printk("Flask:  Starting with no policy loaded.\n");
> +    else if ( flask_enforcing )
>          printk("Flask:  Starting in enforcing mode.\n");

I have a question with regard to XSM in general.

This branching gives me the impression that if no policy is provided
flask is not enforced even if you have flask_enforned=1. What mode is it
in? Enforcing or permissive? Is it in permissive mode until a policy is
loaded? Is it enforcing dummy policy (though it appears to pass every
check)?

Wei.

>      else
>          printk("Flask:  Starting in permissive mode.\n");
> -
> -    return ret;
>  }
>  
>  xsm_initcall(flask_init);
> -- 
> 2.1.0
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel