Re: [Xen-devel] [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 20/02/15 12:30, Ian Campbell wrote:
> On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote:
> 
> Subject: "devices"
> 
>> Xen is currently using list a compatible string to know if the driver
> 
> "using a list of compatible strings"
> 
> rather than "if the driver can use device node" I'd say something like
> "to match drivers against device nodes".

The second part is better. I will use it.

>> can use device node. This leads to have double definition in the GIC
>> code.
> 
> "having double definitions".
> 
> (aside: can we eventually get rid of that duplication somehow?)

I was able to get a rid of the multiple way to define the "list of
compatible string" (see asm-arm/gic.h).

I will give a look to get a rid of the multiple usage (domain_build.c
and gic-v*.c) by introducing a GIC callback. Though, it will be a
follow-up of this patch and I may send it separately.

>> Futhermore Linux drivers is using dt_match_node (actually called of_device_id
> 
> "Furthermore" and "are using"
> 
>> in Linux) to list device supported by the drivers.
> 
> "devices"
> 
> I'd append one more sentence, something like "Remove the existing
> compatible field and replace with a dt_match field". Just to make it
> clear what the change here is.

I will do.

>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> The actual code looks fine, with the commit message fixed up as
> described:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel