Re: [Xen-devel] [OSSTEST PATCH 5/8] standalone: Always set OSSTEST_NO_BASELINE

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-02-25 at 13:01 +0000, Ian Jackson wrote:
> OSSTEST_NO_BASELINE disables the thing where cr-daily-branch decides
> (based on information from sg-check-tested) that the baseline is
> untested and therefore that it ought to do a baseline test instead of
> testing the tip.
> 
> This whole feature is never correct in standalone mode, where there is
> no useful test history database for sg-check-tested to work on.
> 
> In the case where the branch was osstest, not specifying --baseline
> and therefore not having OSSTEST_NO_BASELINE didn't make all that much
> difference because we also have OSSTEST_USE_HEAD=y and currently
> ap-fetch-version-old (wrongfully) honours that, so the `baseline' test
> would use the head anyway.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although:
> -     --baseline)nobaseline=n; shift 1;;
> +     --baseline) echo >&2 'warning: --baseline is obsolete'; shift 1;;

TBH I think you could just nuke it from a tool like this. I rather
suspect noone is using it... I can't even remember why I wanted it.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel