[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH 4/4] xen: credit2: add a few performance counters
for events that are specific to Credit2 (as it happens for Credit1 already). Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx> Cc: Jan Beulich <JBeulich@xxxxxxxx> Cc: Keir Fraser <keir@xxxxxxx> --- xen/common/sched_credit2.c | 23 +++++++++++++++++++++++ xen/include/xen/perfc_defn.h | 15 ++++++++++++++- 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index bf13a84..fa764f9 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -652,6 +652,8 @@ static void reset_credit(const struct scheduler *ops, int cpu, s_time_t now, } } + SCHED_STAT_CRANK(credit_reset); + /* No need to resort runqueue, as everyone's order should be the same. */ } @@ -671,6 +673,7 @@ void burn_credits(struct csched2_runqueue_data *rqd, struct csched2_vcpu *svc, s delta = now - svc->start_time; if ( delta > 0 ) { + SCHED_STAT_CRANK(burn_credits_t2c); t2c_update(rqd, delta, svc); svc->start_time = now; @@ -711,6 +714,7 @@ static void update_max_weight(struct csched2_runqueue_data *rqd, int new_weight, { rqd->max_weight = new_weight; d2printk("%s: Runqueue id %d max weight %d\n", __func__, rqd->id, rqd->max_weight); + SCHED_STAT_CRANK(upd_max_weight_quick); } else if ( old_weight == rqd->max_weight ) { @@ -727,6 +731,7 @@ static void update_max_weight(struct csched2_runqueue_data *rqd, int new_weight, rqd->max_weight = max_weight; d2printk("%s: Runqueue %d max weight %d\n", __func__, rqd->id, rqd->max_weight); + SCHED_STAT_CRANK(upd_max_weight_full); } } @@ -748,6 +753,7 @@ __csched2_vcpu_check(struct vcpu *vc) { BUG_ON( !is_idle_vcpu(vc) ); } + SCHED_STAT_CRANK(vcpu_check); } #define CSCHED2_VCPU_CHECK(_vc) (__csched2_vcpu_check(_vc)) #else @@ -1201,6 +1207,7 @@ static void migrate(const struct scheduler *ops, svc->migrate_rqd = trqd; set_bit(_VPF_migrating, &svc->vcpu->pause_flags); set_bit(__CSFLAG_runq_migrate_request, &svc->flags); + SCHED_STAT_CRANK(migrate_requested); } else { @@ -1221,7 +1228,10 @@ static void migrate(const struct scheduler *ops, update_load(ops, svc->rqd, svc, 1, now); runq_insert(ops, svc->vcpu->processor, svc); runq_tickle(ops, svc->vcpu->processor, svc, now); + SCHED_STAT_CRANK(migrate_on_runq); } + else + SCHED_STAT_CRANK(migrate_no_runq); } } @@ -1575,7 +1585,10 @@ csched2_runtime(const struct scheduler *ops, int cpu, struct csched2_vcpu *snext /* The next guy may actually have a higher credit, if we've tried to * avoid migrating him from a different cpu. DTRT. */ if ( rt_credit <= 0 ) + { time = CSCHED2_MIN_TIMER; + SCHED_STAT_CRANK(runtime_min_timer); + } else { /* FIXME: See if we can eliminate this conversion if we know time @@ -1586,9 +1599,15 @@ csched2_runtime(const struct scheduler *ops, int cpu, struct csched2_vcpu *snext /* Check limits */ if ( time < CSCHED2_MIN_TIMER ) + { time = CSCHED2_MIN_TIMER; + SCHED_STAT_CRANK(runtime_min_timer); + } else if ( time > CSCHED2_MAX_TIMER ) + { time = CSCHED2_MAX_TIMER; + SCHED_STAT_CRANK(runtime_max_timer); + } } return time; @@ -1621,7 +1640,10 @@ runq_candidate(struct csched2_runqueue_data *rqd, * its credit is at least CSCHED2_MIGRATE_RESIST higher. */ if ( svc->vcpu->processor != cpu && snext->credit + CSCHED2_MIGRATE_RESIST > svc->credit ) + { + SCHED_STAT_CRANK(migrate_resisted); continue; + } /* If the next one on the list has more credit than current * (or idle, if current is not runnable), choose it. */ @@ -1766,6 +1788,7 @@ csched2_schedule( { snext->credit += CSCHED2_MIGRATE_COMPENSATION; snext->vcpu->processor = cpu; + SCHED_STAT_CRANK(migrated); ret.migrated = 1; } } diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h index f754331..d3af41f 100644 --- a/xen/include/xen/perfc_defn.h +++ b/xen/include/xen/perfc_defn.h @@ -28,10 +28,10 @@ PERFCOUNTER(vcpu_wake_runnable, "sched: vcpu_wake_runnable") PERFCOUNTER(vcpu_wake_not_runnable, "sched: vcpu_wake_not_runnable") PERFCOUNTER(tickle_idlers_none, "sched: tickle_idlers_none") PERFCOUNTER(tickle_idlers_some, "sched: tickle_idlers_some") +PERFCOUNTER(vcpu_check, "sched: vcpu_check") /* credit specific counters */ PERFCOUNTER(delay_ms, "csched: delay") -PERFCOUNTER(vcpu_check, "csched: vcpu_check") PERFCOUNTER(acct_run, "csched: acct_run") PERFCOUNTER(acct_no_work, "csched: acct_no_work") PERFCOUNTER(acct_balance, "csched: acct_balance") @@ -51,6 +51,19 @@ PERFCOUNTER(migrate_running, "csched: migrate_running") PERFCOUNTER(migrate_kicked_away, "csched: migrate_kicked_away") PERFCOUNTER(vcpu_hot, "csched: vcpu_hot") +/* credit2 specific counters */ +PERFCOUNTER(burn_credits_t2c, "csched2: burn_credits_t2c") +PERFCOUNTER(upd_max_weight_quick, "cshced2: update_max_weight_quick") +PERFCOUNTER(upd_max_weight_full, "cshced2: update_max_weight_full") +PERFCOUNTER(migrate_requested, "cshced2: migrate_requested") +PERFCOUNTER(migrate_on_runq, "cshced2: migrate_on_runq") +PERFCOUNTER(migrate_no_runq, "cshced2: migrate_no_runq") +PERFCOUNTER(runtime_min_timer, "csched2: runtime_min_timer") +PERFCOUNTER(runtime_max_timer, "csched2: runtime_max_timer") +PERFCOUNTER(migrated, "csched2: migrated") +PERFCOUNTER(migrate_resisted, "csched2: migrate_resisted") +PERFCOUNTER(credit_reset, "csched2: credit_reset") + PERFCOUNTER(need_flush_tlb_flush, "PG_need_flush tlb flushes") /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |