Re: [Xen-devel] [PATCH v3 1/3] x86/numa: Allow arbitrary value of PXM in PXM<->node mapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.02.15 at 00:41, <boris.ostrovsky@xxxxxxxxxx> wrote:
> * Made changes to K&R style (which is what this file uses)

I don't find anything K&R style here, and I think the compiler would
have prevented you from doing any such (by way for issuing
warnings and us using -Werror). I'm sure you mean Linux instead.

> @@ -111,8 +154,8 @@ static __init void bad_srat(void)
>       acpi_numa = -1;
>       for (i = 0; i < MAX_LOCAL_APIC; i++)
>               apicid_to_node[i] = NUMA_NO_NODE;
> -     for (i = 0; i < ARRAY_SIZE(pxm2node); i++)
> -             pxm2node[i] = NUMA_NO_NODE;
> +     for (i = 0; i < MAX_NUMNODES; i++)
> +             pxm2node[i].node = NUMA_NO_NODE;

It escapes me why the ARRAY_SIZE() use needed replacing. I'm
going to undo that before committing, and in fact will adjust other
similar bounds checks to use it too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel