Re: [Xen-devel] [PATCH v6 11/23] libxl: functions to build vmemranges for PV guest

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2015-02-26 at 15:55 +0000, Wei Liu wrote:
> Introduce a arch-independent routine to generate one vmemrange per
> vnode. Also introduce arch-dependent routines for different
> architectures because part of the process is arch-specific -- ARM has
> yet have NUMA support and E820 is x86 only.
> 
> For those x86 guests who care about machine E820 map (i.e. with
> e820_host=1), vnode is further split into several vmemranges to
> accommodate memory holes.  A few stubs for libxl_arm.c are created.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Cc: Elena Ufimtseva <ufimtseva@xxxxxxxxx>

> diff --git a/tools/libxl/libxl_vnuma.c b/tools/libxl/libxl_vnuma.c
> index 33d7a3c..04672b5 100644
> --- a/tools/libxl/libxl_vnuma.c
> +++ b/tools/libxl/libxl_vnuma.c
> @@ -14,6 +14,7 @@
>   */
>  #include "libxl_osdeps.h" /* must come before any other headers */
>  #include "libxl_internal.h"
> +#include "libxl_arch.h"
>  #include <stdlib.h>
>  
>  /* Sort vmemranges in ascending order with "start" */
> @@ -142,6 +143,46 @@ out:
>      return rc;
>  }
>  
> +
Aren't you adding an extra, unnecessary, blank line here?

> +int libxl__vnuma_build_vmemrange_pv_generic(libxl__gc *gc,
> +                                            uint32_t domid,
> +                                            libxl_domain_build_info *b_info,
> +                                            libxl__domain_build_state *state)
>

<snip>

Of course, my Reviewed-by still stands... I just noticed this while
having a quick look. So, if you happen to have to resend... :-)

Regards,
Dario

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel