Re: [Xen-devel] [PATCH 3/5] x86: widen NUMA nodes to be allocated from

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-02-27 at 13:27 +0000, Dario Faggioli wrote:
> On Thu, 2015-02-26 at 13:54 +0000, Jan Beulich wrote:
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > 
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> One question (a genuine one, i.e., I'm really not sure what I'm saying
> is correct).
> 
> After this series, vcpu_to_node() (defined in xen/include/xen/numa.h) is
> left with only one use, in xen/arch/arm/domain.c, besides of course
> being used to implement domain_to_node() (still in
> xen/include/xen/numa.h).
> 
> So, provided ARM people (and I'm Cc-ing them) can get rid of that,

Happy to do so if you have advise on what to replace it with, just 0?

We don't do NUMA yet on ARM so that would be fine, but eventually we'd
want the vcpu stack to be allocated in some sort of "sensible relative
to vcpu affinity" location...

>  can
> that macro be removed all together, and domain_to_node(d) be defined
> after d->node_affinity... something like:
> 
>  #define domain_to_node(d) \
>    ( nodes_equal(d->node_affinity, NODE_MASK_ALL) \
>      ? NUMA_NO_NODE : first_node(d->node_affinity) ) 
> 
> I'm asking because I really don't like vcpu_to_node(). And I'm not
> talking about how it is implemented (there probably are not much
> alternatives), I'm saying I don't think it should exist, and I really
> would see value in killing it. :-)
> 
> Thoughts?
> 
> Thanks and Regards,
> Dario



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel