Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sat, 2015-02-28 at 22:20 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 19/02/2015 15:24, Ian Campbell wrote:
> > +static void check_timer_irq_cfg(unsigned int irq, const char *which)
> > +{
> > +    struct irq_desc *desc = irq_to_desc(irq);
> > +
> > +    /*
> > +     * The interrupt contoller driver will update desc->arch.type with
> > +     * the actual type which ended up configured in the hardware.
> > +     */
> > +    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
> > +        return;
> 
> I should have spotted it before ... The timer interrupts can be either 
> level low or high.
> 
> For instance Seattle is using level high interrupts. Therefore, the 
> error message will be odd on this platform.
> 
> I will send a patch Monday to fix it.

Thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel