Re: [Xen-devel] [RFC PATCH 00/19] xen/arm: Add ITS support

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 02/03/15 12:30, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Add ITS support for arm. Following major features
> are supported
>  - GICv3 ITS support for arm64 platform
>  - Supports only single ITS node

Why only one ITS node supported? I though Cavium was using 2 ITS...

>  - LPI descriptors are allocated on-demand
>  - Only ITS Dom0 is supported

Any plan to support guest?

> Vijaya Kumar K (19):
>   xen/arm: add linked list apis
>   xen/arm: its: Import GICv3 ITS driver from linux
>   xen/arm: its: Port ITS driver to xen

A general comment (I haven't read closely the patches). The GICv3 ITS
taken from Linux is modified so heavily (rename function, move out code,
dropping unused code...) that your assumption in patch #1 [1] is wrong.

At the end of this series it would make impossible to backport patch
from Linux.

Regards,

[1] "This is actual GICv3 ITS driver from Linux. [..] This helps to
import any issues found in Linux"

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel