Re: [Xen-devel] [PATCH v4 6/8] xen/iommu: smmu: Add Xen specific code to be able to use the driver

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 02/03/15 13:17, Ian Campbell wrote:
> On Wed, 2015-02-25 at 18:52 +0000, Julien Grall wrote:
>> The main goal is to modify as little the Linux code to be able to port
>> easily new feature added in Linux repo for the driver.
>>
>> To achieve that we:
>>     - Add helpers to Linux function not implemented on Xen
>>     - Add callbacks used by Xen to do our own stuff and call Linux ones
>>     - Only modify when required the code which comes from Linux. If so a
>>     comment has been added with /* Xen: ... */ explaining why it's
>>     necessary.
>>
>> The support for PCI has been commented because it's not yet supported by
>> Xen ARM and therefore won't compile.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Looks good to me now, thanks. Couple of nits inline, but otherwise:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks for the ack.

>> + * This is because Linux has a field iommu_group in the struct device. On 
>> Xen,
>> + * that would require to move so hackery (dummy iommu_group) in a more 
>> generic
> 
> Was "so" here supposed to be "some"?

Yes.

>> @@ -546,6 +819,9 @@ static int register_smmu_master(struct arm_smmu_device 
>> *smmu,
>>      master->of_node                 = masterspec->np;
>>      master->cfg.num_streamids       = masterspec->args_count;
>>  
>> +    /* Xen: Let Xen knows that the device is protected by an SMMU */
> 
> s/knows/know/

Yes.

Given that the series has been acked up to this patch (#6), would it be
possible to apply the patches #1-#6)?

The patch #7 is not strictly necessary, by default Xen will flush the
cache for the PT.

If it's fine for you, I will resend the patch #7 separately.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel