Re: [Xen-devel] [PATCH v6] libxl_set_memory_target: retain the same maxmem offset on top of the current target

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-02 at 11:36 +0000, Wei Liu wrote:
> On Fri, Feb 27, 2015 at 12:45:47PM +0000, Stefano Stabellini wrote:
> > In libxl_set_memory_target when setting the new maxmem, retain the same
> > offset on top of the current target. In the future the offset will
> > include memory allocated by QEMU for rom files.
> > 
> 
> Sorry for not having mentioned this earlier.
> 
> I think the behaviour of this API is changed now (for good reason).
> 
> Ian and Ian, do want need a #define in libxl.h to mark such change?

I'm not sure, but I don't think that changes to the internal
calculations regarding overheads count as a libxl ABI change.

By analogy we don't break ABI/API if Xen happens to need an extra page
of memory to deal with a guest.

Other than Wei's comment about initialising the dominfo this looks good
to me.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel