Re: [Xen-devel] [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-03-02 at 15:25 +0000, Andrew Cooper wrote:
> On 02/03/15 15:13, Ian Campbell wrote:
> > On Tue, 2015-02-17 at 12:56 +0000, Wei Liu wrote:
> >
> >>>> +            LOG(ERROR, "Invalid pnode %d specified", pnode);
> >>> pnode is uint32_t, so should be %u
> > Actually PRId32 is correct for a uint32_t, although I guess %u will work
> > on all platforms we support.
> >
> >
> 
> PRId32 and PRIu32 differ in string representation if the top bit of
> pnode is set.
> 
> pnode is unsigned, so should never be formatted with a signed identifier.

Oops, I did indeed mean PRIu32.

My main point was that the PRI_32 stuff should be used, not %u as you
were suggesting.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel