[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 16/18] efi: create efi_exit_boot()
>>> On 30.01.15 at 18:54, <daniel.kiper@xxxxxxxxxx> wrote: > ..which gets memory map and calls ExitBootServices(). We need this > to support multiboot2 protocol on EFI platforms. Patches from 9 up to here all make sense on the basis that patch 18 does and assuming that you really need all this code moved out to separate functions. How much different is efi_multiboot2() introduced in #18 from what is left of efi_start() at this point? I.e. is splitting out all of this code really needed? If it is, please don't title all these patches "create ..." but "split out ..." or some such - you don't really create the code. Similarly the second sentence above is too imprecise for my taste - "we want to re-use this code to support ..." would seem more to the point. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |