Re: [Xen-devel] [PATCH v3 12/24] xen/arm: Release IRQ routed to a domain when it's destroying

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 20/02/2015 17:41, Julien Grall wrote:
 >>> +    /* Only SPIs are supported */
> > > +    if ( virq < 32 || virq >= vgic_num_irqs(d) )
> > > +        return -EINVAL;
> > > +
> > > +    p = irq_to_pending(d->vcpu[0], virq);
> > > +    if ( !p->desc )
> > > +        return -EINVAL;
> > Are we seeing this pattern a lot? It seems so, I wonder if a helper
> > could be useful:
> >         p = spi_to_pending(d, virq);
> >         if ( !p->desc )
> >             return -EINVAL;
> >
> > with the < 32 check etc in the helper where it only needs commenting on
> > once.
> IIRC, there is only 2 places. I will replace it by an helper.
Hmmmm.... I only found 1 place. So I will keep open-coding in the function.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel