Re: [Xen-devel] [PATCH v9 03/13] tools: Add vmware_hwver support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-02-16 at 18:05 -0500, Don Slutz wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index c219f59..0c27e5c 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -163,6 +163,16 @@
>  #define LIBXL_HAVE_BUILDINFO_HVM_MMIO_HOLE_MEMKB 1
>  
>  /*
> + * The libxl_vga_interface_type has the type for vmware.
> + */
> +#define LIBXL_HAVE_LIBXL_VGA_INTERFACE_TYPE_VMWARE 1
> +
> +/*
> + * libxl_domain_build_info has the u.hvm.vmware_hwver field.
> + */
> +#define LIBXL_HAVE_BUILDINFO_HVM_VMWARE_HWVER 1

Since they are arriving together I think you can use a single umbrella
define indicating thatvmware support is available.

> @@ -450,6 +454,8 @@ int libxl__domain_build(libxl__gc *gc,
>          localents[i++] = libxl_defbool_val(info->u.hvm.acpi_s3) ? "1" : "0";
>          localents[i++] = "platform/acpi_s4";
>          localents[i++] = libxl_defbool_val(info->u.hvm.acpi_s4) ? "1" : "0";
> +        localents[i++] = "platform/vmware_hwver";
> +        localents[i++] = libxl__sprintf(gc, "%"PRId64, 
> info->u.hvm.vmware_hwver);

GCSPRINTF could be used here.

> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 48d661a..34a36d3 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -294,6 +294,8 @@ static void hvm_set_conf_params(xc_interface *handle, 
> uint32_t domid,
>  #if defined(__i386__) || defined(__x86_64__)
>      xc_hvm_param_set(handle, domid, HVM_PARAM_HPET_ENABLED,
>                      libxl_defbool_val(info->u.hvm.hpet));
> +    xc_set_hvm_param(handle, domid, HVM_PARAM_VMWARE_HWVER,
> +                     info->u.hvm.vmware_hwver);

Please use xc_hvm_param_set not the deprecated older version.

With those little nits addresses you may add:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Unless I'm told otherwise I'll assume that this will be committed by the
person who does the hypervisor side.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel